Patchworkβ Look for text/html content types ignoring case

login
register
about
Submitter James Westby
Date 2010-02-16 18:51:00
Message ID <1266346260-3858-1-git-send-email-jw+debian@jameswestby.net>
Download mbox | patch
Permalink /patch/373/
State New
Headers show

Comments

James Westby - 2010-02-16 18:51:00
Some people send html parts as text/HTML or similar, so do a
case-sensitive comparison when checking for html parts.
---
 notmuch.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Edmondson - 2010-02-16 19:11:24
On Tue, 16 Feb 2010 18:51:00 +0000, James Westby <jw+debian@jameswestby.net> wrote:
> Some people send html parts as text/HTML or similar, so do a
> case-sensitive comparison when checking for html parts.

There are various other places where `equal' is used to compare MIME
types with strings. Shouldn't they all be fixed? (I see TEXT/PLAIN
frequently.)

dme.
James Westby - 2010-02-18 17:29:15
On Tue, 16 Feb 2010 19:11:24 +0000, David Edmondson <dme@dme.org> wrote:
> On Tue, 16 Feb 2010 18:51:00 +0000, James Westby <jw+debian@jameswestby.net> wrote:
> > Some people send html parts as text/HTML or similar, so do a
> > case-sensitive comparison when checking for html parts.
> 
> There are various other places where `equal' is used to compare MIME
> types with strings. Shouldn't they all be fixed? (I see TEXT/PLAIN
> frequently.)

I don't see any others in notmuch.el, but I'm not experienced in elisp,
so I may be missing some, care to help me out?

Thanks,

James

Patch

diff --git a/notmuch.el b/notmuch.el
index 0f4ea10..b69c334 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -736,7 +736,7 @@  is what to put on the button."
             (setq mime-type (car (split-string (buffer-substring 
                                                 (match-beginning 1) (match-end 1))))))
 
-          (if (equal mime-type "text/html")
+          (if (equal (downcase mime-type) "text/html")
               (let ((filename (notmuch-show-get-filename)))
                 (with-temp-buffer
                   (insert-file-contents filename nil nil nil t)