| Submitter | David Edmondson |
|---|---|
| Date | 2010-02-15 09:41:49 |
| Message ID | <1266226909-19360-1-git-send-email-dme@dme.org> |
| Download | mbox | patch |
| Permalink | /patch/365/ |
| State | New |
| Headers | show |
Comments
This version is over-eager in marking (non-)signatures. The second call to 'overlay-put' needs to move inside the 'if' a line below. On Mon, 15 Feb 2010 09:41:49 +0000, David Edmondson <dme@dme.org> wrote: > --- > notmuch.el | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/notmuch.el b/notmuch.el > index 8090b2f..3e8e50d 100644 > --- a/notmuch.el > +++ b/notmuch.el > @@ -703,6 +703,7 @@ is what to put on the button." > (let* ((cite-start (match-beginning 0)) > (cite-end (match-end 0)) > (cite-lines (count-lines cite-start cite-end))) > + (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text-face) > (when (> cite-lines (1+ notmuch-show-citation-lines-prefix)) > (goto-char cite-start) > (forward-line notmuch-show-citation-lines-prefix) > @@ -718,6 +719,7 @@ is what to put on the button." > (let* ((sig-start (match-beginning 0)) > (sig-end (match-end 0)) > (sig-lines (1- (count-lines sig-start end)))) > + (overlay-put (make-overlay sig-start end) 'face 'message-cited-text-face) > (if (<= sig-lines notmuch-show-signature-lines-max) > (notmuch-show-region-to-button > sig-start > -- > 1.6.6.1 > dme.
Nice, it works for me. On Mon, 15 Feb 2010 10:03:32 +0000, David Edmondson <dme@dme.org> wrote: > This version is over-eager in marking (non-)signatures. The second call > to 'overlay-put' needs to move inside the 'if' a line below. Could you please send a fixed patch so that it can be applied easilly. Michal
On Tue, 16 Feb 2010 11:22:01 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote: > Nice, it works for me. > > On Mon, 15 Feb 2010 10:03:32 +0000, David Edmondson <dme@dme.org> wrote: > > This version is over-eager in marking (non-)signatures. The second call > > to 'overlay-put' needs to move inside the 'if' a line below. > > Could you please send a fixed patch so that it can be applied easilly. Sebastian posted one this morning. dme.
On Mon, 15 Feb 2010 09:41:49 +0000, David Edmondson <dme@dme.org> wrote: > --- > notmuch.el | 2 ++ Thanks, David. I've pushed this now, (with the later fix from Sebastian applied). -Carl
Patch
diff --git a/notmuch.el b/notmuch.el index 8090b2f..3e8e50d 100644 --- a/notmuch.el +++ b/notmuch.el @@ -703,6 +703,7 @@ is what to put on the button." (let* ((cite-start (match-beginning 0)) (cite-end (match-end 0)) (cite-lines (count-lines cite-start cite-end))) + (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text-face) (when (> cite-lines (1+ notmuch-show-citation-lines-prefix)) (goto-char cite-start) (forward-line notmuch-show-citation-lines-prefix) @@ -718,6 +719,7 @@ is what to put on the button." (let* ((sig-start (match-beginning 0)) (sig-end (match-end 0)) (sig-lines (1- (count-lines sig-start end)))) + (overlay-put (make-overlay sig-start end) 'face 'message-cited-text-face) (if (<= sig-lines notmuch-show-signature-lines-max) (notmuch-show-region-to-button sig-start